Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated add_biochar_pyrolysis #171

Closed
wants to merge 3 commits into from
Closed

Conversation

BertoGBG
Copy link
Contributor

Closes # (if applicable).

Changes proposed in this Pull Request

update functions biochar pyrolysis. fixed error in investment cost and converted all units to tCO2e sequestered

Checklist

  • [OK ] Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • [ OK] Data source for new technologies is clearly stated.
  • [ N.A.] Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • [OK] I consent to the release of this PR's code under the GPLv3 license.

Sorry, something went wrong.

BertoGBG and others added 3 commits January 24, 2025 16:56

Verified

This commit was signed with the committer’s verified signature. The key has expired.
zakkak Foivos Zakkak
for more information, see https://pre-commit.ci
@BertoGBG
Copy link
Contributor Author

suggested reviewer @martavp

PR that concerns biochar only

@BertoGBG BertoGBG closed this Jan 24, 2025
@BertoGBG BertoGBG reopened this Jan 24, 2025
@fneum
Copy link
Member

fneum commented Jan 24, 2025

Nice! Before merging the outputs/US contents need to be restored.

@BertoGBG BertoGBG closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants