Unit test compile cost assumptions - Part 2 #182

finozzifa · 2025-02-19T14:58:11Z

Closes # (if applicable).

Changes proposed in this Pull Request

This pull request proposes a set of unit tests for scripts/compile_cost_assumptions.py, together with some minimal code re-factoring.

This pull request does not contain any major change to the functionalities of the scripts.

Unit tests

The pull request significantly shortens the conftest.py (almost by half). Moreover, it introduces unit tests for the following functions:

add_carbon_capture
add_gas_storage
geometric_series
prepare_inflation_rate

For introducing unit tests, I have introduce some minor changes to the functions. For example, I now pass as function arguments all snakemake.params/.config previously used in functions (but not passed as function arguments).

logger

The pull request proposes to add a configure_logging method to the _helpers.py from pypsa-eur. Moreover, the Snakefile is modified to add log files for the rules compile_cost_assumptions and compile_cost_assumptions_usa.

Checklist

Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
Data source for new technologies is clearly stated.
Newly introduced dependencies are added to environment.yaml (if applicable).
A note for the release notes doc/release_notes.rst of the upcoming release is included.
I consent to the release of this PR's code under the GPLv3 license.

…chnology-data into unit_test_compile_cost_assumptions

…o unit_test_compile_cost_assumptions

finozzifa added 30 commits January 24, 2025 11:34

code: unit test for get_excel_sheets

7fbfb6c

Merge branch 'master' of https://github.com/open-energy-transition/te…

2ec34f1

…chnology-data into unit_test_compile_cost_assumptions

pre-commit

8f40db1

code: move sheet_names to _helpers.py

b2efc33

code: modify years_list

9cf87d5

output: cost outputs

be66811

Merge branch 'master' of https://github.com/open-energy-transition/te…

074e1e0

…chnology-data into unit_test_compile_cost_assumptions

code: merge from master

2b43e07

code: new unit tests

5516b47

code: revert changes to _helpers.py

11543fe

code:fix quick issues

d339277

code: add logger

c31a02f

code: add docstrings

a9aa5df

add pre-commit changes

f07979d

code: modify sheet location method

8af30ca

code: add docstring

d020522

code: unit test clean_up_units

98b92b8

code: add docstring for get_dea_martime_data

45e33c3

code: add unit test for set_specify_assumptions

299220f

code: add docstring for set_specify_assumptions

4afab7d

code: remove assert False

eb2a7ad

code: unit test for set_round_trip_efficiency

01c398d

include pre-commit

a3af10d

code: switch to numpydoc and introduce static types

8dadf6c

code:include pre-commit

43f3391

code: numpydoc and static types for order_data

c5898bf

code:replace print with logger statements

6d20ebb

code: add logger

1e6e000

Merge branch 'master' of https://github.com/PyPSA/technology-data int…

04a4346

…o unit_test_compile_cost_assumptions

code: modify static type

d4c7f5a

finozzifa added 13 commits February 17, 2025 15:45

code: pre-commit for carbon_flow

6dffb71

code: numpydoc for add_egs_data

9864097

code: add unit test for annuity

450caec

code: merge from master

3502f7a

code: update numpydoc and naming

044a1b7

code: add numpydoc to compile_cost_assumptions_usa.py

6bc4579

code: replace list_of_years to years

189f4e5

code: numpydoc for final batch of functions

b3fc382

code: replace NoneType with empty DataFrame

6893e65

code: pre-commit run all

38d6be2

code: new changes

6ffd02b

Merge branch 'master' of https://github.com/PyPSA/technology-data int…

8e49c14

…o unit_test_compile_cost_assumptions

code: add logging to file

9257fdc

finozzifa mentioned this pull request Feb 19, 2025

Add proper logging to repository #165

Open

finozzifa added 16 commits February 19, 2025 15:59

code: pre-commit run --all

518c616

code: add unit test for geometric_series and logger

c72297b

code: numpydoc for geometric_series

114582c

code: update numpydoc

659d0ae

code: shorten conftest.py

dd2ea29

code: shorten the conftest.py

244f97e

code: unit test for prepare_inflation_rate

5fb0048

code: include pre-commit

d22ac06

code: update on conftest.py

22a3437

code: update on conftest.py - 2

2d68c9e

code: add unit test for add_gas_storage

a42d2f8

code: add pre-commit checks

3671445

code: add unit test for add_carbon_capture

7e7e961

code: shorten tests

455e40f

code: shorten test code

c2cb23c

code: shorten test code - 2

3d6644c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unit test compile cost assumptions - Part 2 #182

Unit test compile cost assumptions - Part 2 #182

finozzifa commented Feb 19, 2025 •

edited

Loading

Unit test compile cost assumptions - Part 2 #182

Are you sure you want to change the base?

Unit test compile cost assumptions - Part 2 #182

Conversation

finozzifa commented Feb 19, 2025 • edited Loading

Changes proposed in this Pull Request

Unit tests

logger

Checklist

finozzifa commented Feb 19, 2025 •

edited

Loading