Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(examples): added example about how to handle discords waveform #2565

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs(examples): added example about how to handle discords waveform #2565

wants to merge 1 commit into from

Conversation

Lulalaby
Copy link
Member

No description provided.

@Lulalaby Lulalaby requested a review from a team as a code owner August 29, 2024 18:45
@Lulalaby Lulalaby self-assigned this Aug 29, 2024
@Lulalaby Lulalaby added documentation Improvements or additions to documentation examples Pycord examples and removed documentation Improvements or additions to documentation labels Aug 29, 2024
@Lulalaby Lulalaby added this to the v2.7 milestone Aug 29, 2024
plun1331
plun1331 reviewed Aug 29, 2024
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less method documentation and more describing what the code actually does

@Lulalaby
Copy link
Member Author

.-.

@Lulalaby
Copy link
Member Author

honestly its too complicated to explain 🤣

@Lulalaby Lulalaby requested a review from plun1331 August 29, 2024 19:03
@Lulalaby
Copy link
Member Author

@plun1331 happy now?

@Lulalaby
Copy link
Member Author

ah fuck u precommit

@Lulalaby Lulalaby enabled auto-merge (squash) August 29, 2024 19:07
@plun1331
Copy link
Member

@plun1331 happy now?

That might be too much 😭

@Lulalaby
Copy link
Member Author

@plun1331 happy now?

That might be too much 😭

You wanted docs, you get docs

@yoggys
Copy link
Contributor

yoggys commented Aug 29, 2024 •
edited
Loading

You wanted docs, you get docs

perfect

@JustaSqu1d
Copy link
Member

Why does this example exist

@Lulalaby
Copy link
Member Author

Lulalaby commented Sep 2, 2024

Because some people asked

@Dorukyum
Copy link
Member

Dorukyum commented Sep 3, 2024

This is too complicated for an example, don't you think? We could have a guide page for this.

@plun1331
Copy link
Member

plun1331 commented Sep 3, 2024

This is too complicated for an example, don't you think? We could have a guide page for this.

This would allow us to go more in-depth with our explanations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeloBlivion NeloBlivion Awaiting requested review from NeloBlivion

@JustaSqu1d JustaSqu1d Awaiting requested review from JustaSqu1d

@plun1331 plun1331 Awaiting requested review from plun1331

At least 1 approving review is required to merge this pull request.

Assignees

@Lulalaby Lulalaby

Labels
examples Pycord examples PA: All Contributors pending
Projects
Pycord Releases
Status: In Progress
Milestone
v2.7
Development

Successfully merging this pull request may close these issues.
5 participants
@Lulalaby @plun1331 @yoggys @JustaSqu1d @Dorukyum