Skip to content

Commit

Permalink
minor CI fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
AlpinDale committed Sep 2, 2024
1 parent 0e6c400 commit e63be8e
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 20 deletions.
5 changes: 5 additions & 0 deletions .github/workflows/clang-format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ jobs:
'kernels/punica/bgmv/vec_dtypes.cuh'
'kernels/punica/punica_ops.cu'
'kernels/punica/type_convert.h'
'kernels/quantization/gguf/ggml-common.h'
'kernels/quantization/gguf/dequantize.cuh'
'kernels/quantization/gguf/vecdotq.cuh'
'kernels/quantization/gguf/mmq.cuh'
'kernels/quantization/gguf/mmvq.cuh'
)
find kernels/ \( -name '*.h' -o -name '*.cpp' -o -name '*.cu' -o -name '*.cuh' \) -print \
| grep -vFf <(printf "%s\n" "${EXCLUDES[@]}") \
Expand Down
11 changes: 7 additions & 4 deletions .github/workflows/ruff.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.10"]
python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
steps:
- uses: actions/checkout@v2
- name: Set up Python ${{ matrix.python-version }}
Expand All @@ -25,10 +25,13 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install ruff==0.1.5 codespell==2.2.6 tomli==2.0.1
pip install ruff==0.1.5 codespell==2.3.0 tomli==2.0.1 isort==5.13.2
- name: Analysing the code with ruff
run: |
ruff aphrodite tests
ruff .
- name: Spelling check with codespell
run: |
codespell --toml pyproject.toml
codespell --toml pyproject.toml
- name: Run isort
run: |
isort . --check-only
2 changes: 1 addition & 1 deletion .github/workflows/yapf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ jobs:
pip install toml==0.10.2
- name: Running yapf
run: |
yapf --diff --recursive aphrodite tests
yapf --diff --recursive aphrodite
26 changes: 11 additions & 15 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ build-backend = "setuptools.build_meta"
[tool.ruff]
# Allow lines to be as long as 80.
line-length = 80
exclude = [
"examples/fp8/quantizer/quantize.py"
]

[tool.ruff.lint]
select = [
Expand All @@ -28,28 +31,21 @@ select = [
"SIM",
# isort
# "I",
"G",
]
ignore = [
# wildcard imports
# star imports
"F405", "F403",
# lambda expression assignment
"E731",
# .strip() with multi-character strings
"B005",
# Loop control variable not used within loop body
"B007",
]

[tool.mypy]
python_version = "3.8"

ignore_missing_imports = true

files = "aphrodite"
# TODO: Include the code from Megatron and HuggingFace.
exclude = "aphrodite/modeling/models/|aphrodite/endpoints/kobold/klite.embd"


[tool.codespell]
ignore-words-list = "dout, te, indicies, ist"
skip = "./aphrodite/endpoints/kobold/klite.embd,./kernels/"
ignore-words-list = "dout, te, indicies, ist, subtile"
skip = "./tests/,./aphrodite/endpoints/kobold/klite.embd,./kernels/"

[tool.isort]
use_parentheses = true
skip_gitignore = true

0 comments on commit e63be8e

Please sign in to comment.