-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ROCm build #817
fix: ROCm build #817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nitpicks
sudo patch $ROCM_PATH/lib/llvm/lib/clang/*/include/__clang_hip_cmath.h ./patches/amd.patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if there's multiple versions installed here? Will it return the first one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there shouldn't be more than one version, though I can just make it check rocm version and patch clang 17 for rocm 6.1 and clang 18 for 6.2 if that's better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nvm, I'm too stupid for that. It should be fine as is anyway
@AlpinDale can it be merged? |
@Naomiusearch sorry for the delay. I forgot to mention: I tested this PR a bit more and it seems to break AWQ/GPTQ marlin entirely. I planned to redo this PR but I got distracted. I'll finish it up today. |
I tested this some more and AWQ needs more work to be fixed. Can you undo the changes related to gptq_marlin? We can merge the PR then. |
I have no idea what to put here so...
Pozdrawiam z rodzinką :3