Migrate to Quicknode for ipfs upload #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhsanRns
requested review from
MikeSofaer,
faisalnaveedRNS and
kjawadDeveloper2
as code owners
easel/lib/easel_provider.dart
Outdated
| _uploadProgressController.sink.add(value); | ||
| }, | ||
| ); | ||
| final whereToUpload = QuickNode.listOfQuickNodeAllowedExtension().contains(fileExtension.toLowerCase()); |
There was a problem hiding this comment.
The name doesn't justifies what it is doing. Maybe you should use shouldUploadToQuickNode
easel/lib/easel_provider.dart
Outdated
| ); | ||
| } else { | ||
| response = await repository.uploadFileUsingQuickNode( | ||
| uploadIPFSInput: UploadIPFSInput( |
There was a problem hiding this comment.
Does quick node doesn't provides any support for the upload progress? Kindly check line 824.
There was a problem hiding this comment.
yes it is supported working on it
easel/lib/easel_provider.dart
Outdated
| response = await repository.uploadFileUsingQuickNode( | ||
| uploadIPFSInput: UploadIPFSInput( | ||
| fileName: fileName, | ||
| filePath: file?.path ?? '', |
There was a problem hiding this comment.
If the file doesn't have a path then it shouldn't be uploaded.
| uploadIPFSOutput.info?.size ?? '0', | ||
| ), | ||
| status: uploadIPFSOutput.status, | ||
| )), |
There was a problem hiding this comment.
Suggested change
| )), | |
| ),), |
| @@ -36,6 +36,9 @@ class _ChooseFormatScreenState extends State<ChooseFormatScreen> { | |||
| return; | |||
| } | |||
|
|
|||
|
|
|||
|
|
|||
|
|
|||
There was a problem hiding this comment.
You can revert these spaces.
|
|
||
| final response = await http.Response.fromStream(await request.send()); | ||
|
|
||
| final a = UploadIPFSOutput.fromJson(json.decode(response.body) as Map<String, dynamic>); |
There was a problem hiding this comment.
Suggested change
| final a = UploadIPFSOutput.fromJson(json.decode(response.body) as Map<String, dynamic>); | |
| final uploadIPFSOutput = UploadIPFSOutput.fromJson(json.decode(response.body) as Map<String, dynamic>); |
Comment on lines
76
to
78
| Map<String, dynamic> toJson() { | ||
| return {}; | ||
| } |
There was a problem hiding this comment.
Is this method needed?
| final String? size; | ||
|
|
||
| Info({ | ||
| this.size, |
There was a problem hiding this comment.
Suggested change
| this.size, | |
| this.size |
Comment on lines
112
to
115
| Pin({ | ||
| this.cid, | ||
| this.name, | ||
| }); |
There was a problem hiding this comment.
Suggested change
| Pin({ | |
| this.cid, | |
| this.name, | |
| }); | |
| Pin({ | |
| this.cid, | |
| this.name | |
| }); |
| } | ||
|
|
||
| void _registerLocalDataSources() { | ||
| sl.registerLazySingleton<LocalDataSource>(() => LocalDataSourceImpl(sharedPreferences: sl(), database: sl(), cacheManager: sl())); | ||
| } | ||
|
|
||
| void _registerProviders() { | ||
| sl.registerLazySingleton<EaselProvider>(() => EaselProvider(videoPlayerHelper: sl(), audioPlayerHelperForFile: sl(), fileUtilsHelper: sl(), repository: sl(), audioPlayerHelperForUrl: sl(), mediaInfo: sl())); | ||
| sl.registerLazySingleton<EaselProvider>( | ||
| () => EaselProvider(videoPlayerHelper: sl(), audioPlayerHelperForFile: sl(), fileUtilsHelper: sl(), repository: sl(), audioPlayerHelperForUrl: sl(), mediaInfo: sl())); |
There was a problem hiding this comment.
Suggested change
| () => EaselProvider(videoPlayerHelper: sl(), audioPlayerHelperForFile: sl(), fileUtilsHelper: sl(), repository: sl(), audioPlayerHelperForUrl: sl(), mediaInfo: sl())); | |
| () => EaselProvider(videoPlayerHelper: sl(), audioPlayerHelperForFile: sl(), fileUtilsHelper: sl(), repository: sl(), audioPlayerHelperForUrl: sl(), mediaInfo: sl(),)); |
faisalnaveedRNS
approved these changes
Apr 1, 2024
# Conflicts: # easel/android/build.gradle
kjawadDeveloper2
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change