support mounting routes without a trailing slash #3415
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #1639. Closes #406.
The gist is this snippet that was added to the docs.
This is backward-incompatible for anyone mounting routes and using an empty string.
Alternative approaches that could maintain compatibility:
This is somewhat cumbersome.
add_route
that a user could opt into.I'm open to something like this and am curious what people think. Pyramid has a somewhat ingrained history of supporting
'' == '/'
and this makes them different, but only in a specific use case. When used from main or without a route_prefix, they are still equivalent and result in a trailing slash. I'm not convinced it's worth the incompatibility.ping @nek4life