Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve include mechanism with not None route_prefix #719

Closed
wants to merge 1 commit into from

Conversation

ponomar
Copy link

@ponomar ponomar commented Nov 11, 2012

Let's suppose we have:

def add_cabinet_routes(config):
    config.add_route('cabinet.index_not_slashed', '')
    config.add_route('cabinet.index_slashed', '/')
    # much more routes

# in main() 
config.include(add_cabinet_routes, prefix_url='/cabinet')

Now: we will have 2 equivalent urls: /cabinet/ and /cabinet/
Will be: we will have 2 distinct urls: /cabinet and /cabinet/

So now we can't add base url without trailing slash with existent route_prefix.

@mcdonc
Copy link
Member

mcdonc commented Nov 11, 2012

Sorry, talk about this has been beaten to death in issue #406 . This patch won't be accepted.

@mcdonc mcdonc closed this Nov 11, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants