Avoid calling the deprecated "findAll" BeautifulSoup4 method #263
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest release of BeautifulSoup4 (4.13.0, released yesterday) has started to emit DeprecationWarnings when calling methods that have been marked as deprecated for over a decade, and the deprecated methods are scheduled to be removed in version 4.15.0: https://git.launchpad.net/beautifulsoup/commit/?id=e9629a8aafc737578bd509ffc6b989ffedae7c41. This changes the one call to `findAll` to instead be `find_all` to avoid triggering a DeprecationWarning and to ensure the library keeps working with newer versions of BeautifulSoup4.
|
I should point out, that I am not aware if this fixes all possible calls to deprecated methods in WebTest. This is just the one instance that is triggered a lot in our code base. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest release of BeautifulSoup4 (4.13.0, released yesterday) has started to emit DeprecationWarnings when calling methods that have been marked as deprecated for over a decade, and the deprecated methods are scheduled to be removed in version 4.15.0: https://git.launchpad.net/beautifulsoup/commit/?id=e9629a8aafc737578bd509ffc6b989ffedae7c41.
This changes the one call to
findAllto instead befind_allto avoid triggering a DeprecationWarning and to ensure the library keeps working with newer versions of BeautifulSoup4.