-
Notifications
You must be signed in to change notification settings - Fork 551
Sensitivity calculation for named expressions #3685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3685 +/- ##
==========================================
- Coverage 89.20% 89.19% -0.01%
==========================================
Files 892 892
Lines 102978 102997 +19
==========================================
+ Hits 91857 91872 +15
- Misses 11121 11125 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor comments but otherwise this looks fine.
@@ -62,7 +63,7 @@ def get_dsdp_dfdp(model, theta): | |||
Returns | |||
------- | |||
scipy.sparse.csc_matrix, csc_matrix, ComponentMap, ComponentMap | |||
ds/dp (ns + np by np), df/dp (1 by np), row map, column map. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you change the dimension of ds/dp in the docstring without changing anything in the implementation? You just made this change (i.e. changing the dimension from ns by np
to ns+np by np
) in #3655
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mistake. Somehow, I accidently reverted to a older version of the file and things got a little mixed up. I'll fix it.
Co-authored-by: Bethany Nicholson <[email protected]>
Fixes None
Summary/Motivation:
This adds sensitivity calculations for named expressions to the pynumero sensitivity calculations in the sensitivity toolbox. Usually, it is probably better to add a variable to the model, but on rare occasions that can cause trouble.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: