-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Project Setup #65
Project Setup #65
Conversation
@TanyaMushonga, thank you for setting this up. I'll take a close look at the PR soon. The PR is failing eslint check, could you please run eslint on your changes and ensure that there are no eslint errors? |
@terrameijar Ok let me fix rhe eslint errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TanyaMushonga, let's use a different placeholder picture for this part of the UI. You can use a service like this one to generate a fake image: https://pravatar.cc/
I hadn't thought of this but we should implement a profile picture upload feature in the backend that frontend users can use at registration. I'll create an issue for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem let me work on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TanyaMushonga thank you, this looks good so far. There only change I'll ask you to make is removing your picture from the project and using a fake avatar instead.
@terrameijar l have fixed the issue of placeholder profile picture |
@terrameijar can you review and merge the changes that l have made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good. Thanks @TanyaMushonga !
Title:
Initial Project Setup with Theming, Typography, Folder Structure, and Navigation Bar
Description:
This PR sets up the foundation for the open-source project by implementing key structural and UI elements. Below is a breakdown of the changes made:
Theming and Typography:
Project Folder Structure:
Navigation Bar:
Testing:
Next Steps: