[FIX] unstable TorchBackend.sqrtm() around repeated eigenvalues #774
+40
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Implemented closed-form differential for
TorchBackend.sqrtm(SPD matrix sqrt) with comparable time complexity (1 eigendecomposition) but stable around repeated eigenvaluesMotivation and context / Related issue
See issue #773
How has this been tested (if it applies)
sqrtmstill passTorchBackend.sqrtmintest/test_backend.pyPR checklist