Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging some old code before switching from master to main #132

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

QB3
Copy link
Owner

@QB3 QB3 commented Nov 26, 2021

  • harmonizing first-order methods in examples

@QB3 QB3 requested a review from Klopfe November 26, 2021 22:57
@codecov-commenter
Copy link

Codecov Report

Merging #132 (b71ec72) into master (6c84233) will increase coverage by 0.02%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
+ Coverage   81.80%   81.83%   +0.02%     
==========================================
  Files          42       42              
  Lines        3347     3352       +5     
  Branches      353      353              
==========================================
+ Hits         2738     2743       +5     
  Misses        511      511              
  Partials       98       98              
Flag Coverage Δ
unittests ∅ <ø> (∅)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sparse_ho/ho.py 50.00% <ø> (ø)
sparse_ho/models/svm.py 71.36% <50.00%> (ø)
sparse_ho/utils_plot.py 68.75% <90.90%> (+1.64%) ⬆️
sparse_ho/algo/implicit.py 96.96% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c84233...b71ec72. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants