warning: usage of `Iterator::fold` on a type that implements `Try` --> src/builder.rs:834:10 | 834 | .fold(Some(ValueSum::zero()), |acc, action| { | __________^ 835 | | acc? + action.value_sum() 836 | | }) | |__________^ help: use `try_fold` instead: `try_fold(ValueSum::zero(), |acc, action| ...)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold = note: `#[warn(clippy::manual_try_fold)]` on by default

warning: doc list item without indentation --> src/bundle/commitments.rs:52:5 | 52 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `#[warn(clippy::doc_lazy_continuation)]` on by default help: indent this line | 52 | /// with ZCASH_ORCHARD_ACTIONS_COMPACT_HASH_PERSONALIZATION | +

warning: doc list item without indentation --> src/bundle/commitments.rs:54:5 | 54 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 54 | /// with ZCASH_ORCHARD_ACTIONS_MEMOS_HASH_PERSONALIZATION | +

warning: doc list item without indentation --> src/bundle/commitments.rs:56:5 | 56 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION | ^^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 56 | /// with ZCASH_ORCHARD_ACTIONS_NONCOMPACT_HASH_PERSONALIZATION | +

warning: doc list item without indentation --> src/bundle/commitments.rs:57:5 | 57 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244] | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation help: indent this line | 57 | /// as defined in [ZIP-244: Transaction Identifier Non-Malleability][zip244] | +++

warning: first doc comment paragraph is too long --> src/circuit.rs:96:1 | 96 | / /// The `OrchardCircuit` trait defines an interface for different implementations of the PLONK circuit 97 | | /// for the different Orchard protocol flavors (Vanilla and ZSA). It serves as a bridge between 98 | | /// plonk::Circuit interfaces and specific requirements of the Orchard protocol's variations. | |_ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_long_first_doc_paragraph = note: `#[warn(clippy::too_long_first_doc_paragraph)]` on by default

warning: use of a fallible conversion when an infallible one could be used --> src/keys.rs:270:27 | 270 | self.0.to_bytes().try_into().unwrap() | ^^^^^^^^^^^^^^^^^^^ | = note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions = note: `#[warn(clippy::unnecessary_fallible_conversions)]` on by default help: use | 270 - self.0.to_bytes().try_into().unwrap() 270 + self.0.to_bytes().into() |

warning: use of a fallible conversion when an infallible one could be used --> src/keys.rs:337:27 | 337 | self.0.to_bytes().try_into().unwrap() | ^^^^^^^^^^^^^^^^^^^ | = note: converting `GenericArray<u8, UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>>` to `[u8; 32]` cannot fail = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fallible_conversions help: use | 337 - self.0.to_bytes().try_into().unwrap() 337 + self.0.to_bytes().into() |

warning: unused return value of `std::hash::Hasher::finish` that must be used --> src/note/asset_base.rs:114:9 | 114 | h.finish(); | ^^^^^^^^^^ | = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 114 | let _ = h.finish(); | +++++++