Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit: Fix balance violation #78

Merged
merged 5 commits into from
Jul 24, 2023
Merged

Conversation

ConstanceBeguier
Copy link

@ConstanceBeguier ConstanceBeguier commented Jul 6, 2023

To prevent balance violations, we have replaced the constraint "(v_old = 0 and split_flag = 0) or (root = anchor)"
with the constraint "(v_old = 0 and is_native_asset = 1) or (root = anchor)".
Previously, an adversary could use a zero-valued ZSA note to violate balance by setting v_old=0, v_new!=0, is_native_asset=0, split_flag=0.

Limit the version of dashmap (< 5.5) because recent dashmap versions required rust version 1.64 or newer
Limit the version of hashbrown (<0.13) because recent hashbrown versions required rust version 1.64 or newer

@QED-it QED-it deleted a comment from what-the-diff bot Jul 6, 2023
@ConstanceBeguier ConstanceBeguier merged commit 081513b into zsa1 Jul 24, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants