Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding burn field to serialized bundle #10

Closed
wants to merge 4 commits into from
Closed

Conversation

dmidem
Copy link

@dmidem dmidem commented May 17, 2023

This pull request introduces a change to the transaction.py script in the zcash_test_vectors repository. The modification adds a burn vector to the serialized bundle, covering both empty and non-empty burn scenarios. This change is essential for generating appropriate test vectors for the updated version of the librustzcash/zcash_primitives crate from the burn_read_write_validate branch. On this branch, a "burn" field was added into serialization and deserialization functions for the bundle.

Furthermore, in this pull request, I have refactored orchard/asset_id.py to add a derive_random_asset base function and used it to generate asset bases for the burn items.

Additionally, the Rust, JSON, and Zcash output files have been updated to reflect these changes.

@dmidem dmidem requested a review from PaulLaux May 17, 2023 17:41
@vivek-arte
Copy link

This PR is outdated, and the material is subsumed into #22 -- which includes both burn and issue additions to the transaction ID and sighash generation

@vivek-arte vivek-arte closed this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants