Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Swaps, diff for reference #50

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Asset Swaps, diff for reference #50

wants to merge 10 commits into from

Conversation

vivek-arte
Copy link

This is a reference of the changes made for ZSA Swaps above the changes for the ZSA Protocol.

The changes are majorly in ZIP 228: Zcash Shielded Asset Swaps, with minor changes in the README.rst and index.html files to add the new ZIP to the index.

Copy link

netlify bot commented Feb 8, 2024

Deploy Preview for zcash-zips-qedit ready!

Name Link
🔨 Latest commit 4d73b97
🔍 Latest deploy log https://app.netlify.com/sites/zcash-zips-qedit/deploys/67053846ade31200093c1fea
😎 Deploy Preview https://deploy-preview-50--zcash-zips-qedit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vivek-arte vivek-arte marked this pull request as draft February 8, 2024 14:21
@vivek-arte vivek-arte changed the base branch from zsa1 to main February 12, 2024 09:10
Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments regarding fees.

zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
zip-0228.rst Outdated Show resolved Hide resolved
@vivek-arte vivek-arte force-pushed the asset_swaps branch 2 times, most recently from 122a4f6 to 2c3898a Compare August 13, 2024 07:03
vivek-arte added a commit that referenced this pull request Sep 17, 2024
This makes updates based on the comments made on #50.
In swap bundle figure,
- replace spend and output notes by actions
- fix bundle value balance
vivek-arte added a commit that referenced this pull request Oct 16, 2024
This makes updates based on the comments made on #50.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants