Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swaps] Updates to the Asset Swaps fees rationale and specification #63

Open
wants to merge 15 commits into
base: asset_swaps
Choose a base branch
from
Open

[Swaps] Updates to the Asset Swaps fees rationale and specification #63

wants to merge 15 commits into from

Commits on Aug 13, 2024

  1. creation of Asset Swaps ZIP based on Google Doc Draft

    @vivek-arte
    vivek-arte committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    8866bf2 View commit details
    Browse the repository at this point in the history

  2. Fixing typo, clarifying information about Partial Fills

    @vivek-arte
    vivek-arte committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    3a626f4 View commit details
    Browse the repository at this point in the history

  3. correcting bytes[] to byte[]

    @vivek-arte
    vivek-arte committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    721f837 View commit details
    Browse the repository at this point in the history

  4. making changes based on review comments

    @vivek-arte
    vivek-arte committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2bd8ec7 View commit details
    Browse the repository at this point in the history

  5. updates to ZIP 228 files and readme post restructuring changes

    @vivek-arte
    vivek-arte committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2c3898a View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2024

  1. updating path to images post restructuring so that images render corr… 

    …ectly
    @vivek-arte
    vivek-arte committed Aug 30, 2024
    Configuration menu
    Copy the full SHA
    64255cf View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Updates to Asset Swaps ZIP based on review comments (#62) 

    This makes updates based on the comments made on #50.
    @vivek-arte
    vivek-arte authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2786578 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. rewording the fees section and rationale

    @vivek-arte
    vivek-arte committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    ec123f9 View commit details
    Browse the repository at this point in the history

  2. updates based on review comments

    @vivek-arte
    vivek-arte committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3977a28 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. edits based on review comments - first pass

    @vivek-arte
    vivek-arte committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7d2576a View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge branch 'asset_swaps' into swaps_fees_reword

    @vivek-arte
    vivek-arte committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    55807eb View commit details
    Browse the repository at this point in the history

  2. [Swaps] Update to the way the Spend Authorization Signature is calcul… 

    …ated. (#73)

This changes the Spend Authorization Signature to use the `orchard_action_groups_digest`.
    @vivek-arte
    vivek-arte authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    be01c7e View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. removing additional preAuthActionGroup terms

    @vivek-arte
    vivek-arte committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    82bf5ed View commit details
    Browse the repository at this point in the history

  2. changes based on review comments

    @vivek-arte
    vivek-arte committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    8c3c61c View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. further changes based on review comments

    @vivek-arte
    vivek-arte committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    a35f1c5 View commit details
    Browse the repository at this point in the history