[ZSA][Fees] Refactoring the ZSA Fees #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the issuance_fee as a multiple of the marginal_fee
✅ Deploy Preview for zcash-zips-qedit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
vivek-arte
changed the title
PaulLaux
reviewed
Oct 7, 2024
Comment on lines
+315
to
+316
| :math:`issuance\_fee` :math:`100 \cdot marginal\_fee` zatoshis per issuance action (as defined below) | ||
| :math:`finalize\_fee` :math:`20 \cdot marginal\_fee` zatoshis per issuance action (as defined below) |
There was a problem hiding this comment.
marginal_fee is already denominated in zatoshi, no need to repeat again
| @@ -310,7 +325,7 @@ calculated in zatoshis per the following formula: | |||
| zsa\_logical\_actions &=& logical\_actions \;+ \\ | |||
| & & nTotalOutputsZsaIssuance \\ | |||
| zsa\_conventional\_fee &=& marginal\_fee \cdot \mathsf{max}(grace\_actions, zsa\_logical\_actions) \;+ \\ | |||
| & & issuance\_fee \cdot nIssueActions \;+ \\ | |||
| & & issuance\_fee \cdot nIssueActions \;- \\ | |||
There was a problem hiding this comment.
why - ?
need to provide rationale for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites ZIP 317 in order to specify which are the revisions made for the ZSA Protocol.
It also rewrites the issuance_fee as a multiple of the marginal_fee for easier analysis.