Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swaps] Update to the way the Spend Authorization Signature is calculated. #73

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

vivek-arte
Copy link

This changes the Spend Authorization Signature to use the SIGHASH as before.

Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for zcash-zips-qedit ready!

Name Link
🔨 Latest commit cd278cb
🔍 Latest deploy log https://app.netlify.com/sites/zcash-zips-qedit/deploys/6710e73d19d0e8000749a1e2
😎 Deploy Preview https://deploy-preview-73--zcash-zips-qedit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not approve it for now. Let's use this PR to make the changes we discussed today.
(actionGroupHash and SigHash)

@PaulLaux PaulLaux changed the base branch from asset_swaps to swaps_fees_reword October 10, 2024 07:40
@PaulLaux PaulLaux changed the base branch from swaps_fees_reword to zsa1 October 10, 2024 07:41
@PaulLaux PaulLaux changed the base branch from zsa1 to asset_swaps October 10, 2024 07:41
@vivek-arte vivek-arte changed the base branch from asset_swaps to swaps_fees_reword October 16, 2024 13:17
@vivek-arte
Copy link
Author

I am merging these changes into #63 in order to combine these two PRs into a single one for review.

@vivek-arte vivek-arte merged commit be01c7e into swaps_fees_reword Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants