Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give --version the success exit code #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

give --version the success exit code #1

wants to merge 1 commit into from

Conversation

QJKX
Copy link
Owner

@QJKX QJKX commented Dec 28, 2021

Change exit code of jamulus --version from 1 to 0.

Printing version information as requested is not a failure, so by convention the program should exit with an exit code of 0.
A non-zero exit code would interrupt a shell script following the convention.

  • I've verified that this Pull Request follows the general code principles
  • I tested my code and it does what I want
  • My code follows the style guide
  • I waited some time after this Pull Request was opened and all GitHub checks completed without errors.
  • I've filled all the content above

Change exit code of `jamulus --version` from 1 to 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant