-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
improve setting in CHP utility stream prices
- Loading branch information
Showing
1 changed file
with
29 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e2d8f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiananf2 FYI, this will increase price (almost $1/gal), I think it's because the change in new lines 318-320. Because now
biosteam
hasnatural_gas
as a utility stream, CHP cannot offsetnatural_gas
but the previous codes couldn't differentiatenatural_gas
from steams.Let me know if you see problems, otherwise I'll update the test results when I merge my recent changes into
main
.5e2d8f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yalinli2, did you remove the natural gas price in systems.py (
CHP.ins[1].price = 0.1685
)?5e2d8f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jiananf2 no I didn't, I made sure it's the same across the system, regardless of you set it through:
CHP.ins[0].price
CHP.fuel_price
CHP.natural_gas_price
additionally, I found that when biosteam calculating the natural gas costs, it'll look like whether you accounted for it as a chemical so it won't double-count
also, (I forgot what else bugs I fixed) now results are closer prior to the changes
pfas
branchhttps://github.com/QSD-Group/EXPOsan/blob/2a95b70f89623b12ace86cdd83a793614d1394aa/tests/test_htl.py#L38-L51
current simulation
5e2d8f0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!