Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in recent updates; release new version #127

Merged
merged 26 commits into from
Dec 10, 2024
Merged

Merge in recent updates; release new version #127

merged 26 commits into from
Dec 10, 2024

Conversation

yalinli2
Copy link
Member

This should work with thermosteam==0.48.0, biosteam==2.48.1

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 49.36508% with 319 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base (b97d4d1) to head (d2edfe6).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
qsdsan/processes/_pm2asm2d.py 42.50% 165 Missing ⚠️
qsdsan/sanunits/_excretion.py 12.74% 89 Missing ⚠️
qsdsan/sanunits/_membrane_bioreactor.py 73.88% 32 Missing and 3 partials ⚠️
qsdsan/sanunits/_suspended_growth_bioreactor.py 80.00% 4 Missing and 3 partials ⚠️
qsdsan/processes/_asm2d.py 25.00% 6 Missing ⚠️
qsdsan/processes/_adm1_p_extension.py 44.44% 5 Missing ⚠️
qsdsan/sanunits/_junction.py 20.00% 4 Missing ⚠️
qsdsan/processes/_aerobic_digestion_addon.py 91.42% 1 Missing and 2 partials ⚠️
qsdsan/sanunits/_anaerobic_reactor.py 25.00% 3 Missing ⚠️
qsdsan/_waste_stream.py 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   73.52%   72.75%   -0.77%     
==========================================
  Files          96       98       +2     
  Lines       19045    19645     +600     
  Branches     1668     1702      +34     
==========================================
+ Hits        14002    14292     +290     
- Misses       4487     4789     +302     
- Partials      556      564       +8     
Flag Coverage Δ
unittests 72.75% <49.36%> (-0.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yalinli2
Copy link
Member Author

I'll approve this PR, tho it's dragging the coverage down.

@yalinli2 yalinli2 merged commit af5acab into main Dec 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants