chat messages selectable / copyable #521
Conversation
|
current state is: the chat messages are copyable and selectable, but links are not clickable. |
|
@thechauffeur is it madantory to have it clickable and displayed as link? i have probably a solution for it but its kinda tricky |
|
This is definitely a good solution for now as it eases the greatest pain in using chat. edit: This means we do not need the links to be clickable now. |
| @@ -822,3 +822,11 @@ VBox.spaced, HBox.spaced { | |||
| .error-textfield { | |||
| -fx-effect: dropshadow(three-pass-box, red, 8, 0.0, 0, 1); | |||
| } | |||
|
|
|||
| .selectable-text * { | |||
There was a problem hiding this comment.
Works but in html this would be very expensive because it selects from right to left and would select every element and then check its perent recursively. Not sure how javafx does this but I would prefer to replace * by the exact element if you can figure that out. Scenic View might be of help...
| DropMessage message = receiveMessages().get(0); | ||
| assertEquals(DropMessageRepository.PAYLOAD_TYPE_MESSAGE, message.getDropPayloadType()); | ||
| assertEquals("line1\nline2", TextMessage.fromJson(message.getDropPayload()).getText()); | ||
| private void writeTwoLinesOfText(String line1, String line2) { |
There was a problem hiding this comment.
unused. Either remove it or use it instead of writeTwoLinesOfText. I would prefer the latter because it increases the tests readability / clearifies the intent:
writeTwoLinesOfText("line1", "line2");
...
assertEquals("line1\nline2", ...);
|
doesn't work for me: |
|
warmer... |
| .selectable-text .text-area .scroll-pane, | ||
| .selectable-text .text-area .viewport, | ||
| .selectable-text .text-area .content { | ||
| -fx-background-color: #4d4d4d; |
There was a problem hiding this comment.
let the color at least depend on the .own and .other class.
And I don't think you need to use that many selectors when you set the color. The topmost should be enough to lay over all other elements.
|
not that warm actually ;) wrapping is broken, too |
| @@ -78,6 +79,8 @@ public void run() { | |||
| }); | |||
|
|
|||
| trayNotifications(tray); | |||
|
|
|||
| ScenicView.show(primaryStage.getScene()); | |||
There was a problem hiding this comment.
debugging, please don't commit that
No description provided.