522 chat click links #537
522 chat click links #537
Conversation
…delimiters of HyperLinkLabel that he can build clickable links out of it. and add the eventlistener to open the link in browser
| String regex = "(https?:\\/\\/(?:www\\.|(?!www))[^\\s\\.]+\\.[^\\s]{2,}|www\\.[^\\s]+\\.[^\\s]{2,})"; | ||
| Pattern pattern = Pattern.compile(regex, Pattern.CASE_INSENSITIVE | Pattern.COMMENTS | Pattern.MULTILINE); | ||
| Matcher matcher = pattern.matcher(message); | ||
| String result = matcher.replaceAll("[$1]"); |
There was a problem hiding this comment.
Extract this replace stuff to a different place, it shouldn't be in a renderer.
| public Consumer<String> browserOpener; | ||
|
|
||
| public PlaintextMessageRenderer() { | ||
| browserOpener = (uri) -> { |
There was a problem hiding this comment.
You can also initialize it inline where you declare the member. Functionally it is identical.
A better way do to this is imho to create a dedicated browser opener interactor and replace the real one, which has Desktop.getDesktop() stuff, with a testable browser opener.
|
what's the state here? |
|
gonna check this |
… into 522_chat_click_links
…ct to simplify the text flow wrapping stuff
add the alias into the textflow some text wrap wont work gonna check on it later fully replaced old chat stuff
| @@ -118,7 +118,7 @@ private void showLayoutStage() { | |||
| Scene layoutScene = new Scene(view, 900, 600, true, SceneAntialiasing.BALANCED); | |||
| Platform.runLater(() -> primaryStage.setScene(layoutScene)); | |||
| primaryStage.show(); | |||
| closeStage(); | |||
| // closeStage(); | |||
There was a problem hiding this comment.
needs to be activated again
| import java.util.Collections; | ||
| import java.util.List; | ||
|
|
||
| class QabelChatSkin extends BehaviorSkinBase<QabelChatLabel, BehaviorBase<QabelChatLabel>> { |
There was a problem hiding this comment.
remove this legacy code
| @@ -458,28 +486,6 @@ VBox.spaced, HBox.spaced { | |||
| -fx-border-width: 0 0 1px 0; | |||
| } | |||
|
|
|||
| .hyperlink { | |||
There was a problem hiding this comment.
where has this been used before? seems like there are links in the gui now that are no more visible as links...
There was a problem hiding this comment.
was in the about screen but isn't used anymore
|
feedback from po for the links:
|
|
and the new message indicator does never disappear with this code |
|
and it only took two regular expressions... |
| } | ||
| } | ||
|
|
||
| private boolean hasValidTld(URI uri) throws URISyntaxException { |
There was a problem hiding this comment.
I really think that filtering out unknown TLDs is not a good idea.
resolves #522