Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 366: TBLPROPERTIES consistency between log, catalog and Qbeast internals #367

Merged
merged 11 commits into from
Jul 30, 2024
Merged

Issue 366: TBLPROPERTIES consistency between log, catalog and Qbeast internals #367

merged 11 commits into from
Jul 30, 2024

Conversation

osopardo1
Copy link
Member

@osopardo1 osopardo1 commented Jul 26, 2024 •
edited
Loading

Description

Fixes #366

Type of change

Bug fix.

Checklist:

Here is the list of things you should do before submitting this pull request:

  • New feature / bug fix has been committed following the Contribution guide.
  • Add logging to the code following the Contribution guide.
  • Add comments to the code (make it easier for the community!).
  • Change the documentation.
  • Add tests.
  • Your branch is updated to the main branch (dependent changes have been merged).

How Has This Been Tested? (Optional)

Tests on QbeastCatalogTest and QbeastCatalogIntegrationTest.

@osopardo1 osopardo1 marked this pull request as ready for review July 26, 2024 14:29
cdelfosse
cdelfosse approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@cdelfosse cdelfosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to validate it in testing environment.

@Jiaweihu08 Jiaweihu08 merged commit 71ee262 into Qbeast-io:main Jul 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdelfosse cdelfosse cdelfosse approved these changes

@Jiaweihu08 Jiaweihu08 Jiaweihu08 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TBLPROPERTIES not updated on Spark Catalog
3 participants
@osopardo1 @cdelfosse @Jiaweihu08