lots of changes and fixes cleanup too #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need more changes wait for it |
DevX32
changed the title
Manason
requested changes
Oct 18, 2023
| help = 'Toggle Admin Car', | ||
| restricted = 'admin', | ||
| }, function(source) | ||
| TriggerClientEvent('qb-admin:client:SaveCar', source) |
There was a problem hiding this comment.
I don't think this needs to be a client event. Can't the spawning and configuration of the car largely be handled server side? Is this command even useful? Admins can already do /car [model] after all
There was a problem hiding this comment.
its saves the car / give owership of veh/car
| @@ -122,6 +122,31 @@ RegisterNetEvent('qb-admin:server:changeplayerdata', function(Selected, Selected | |||
| PlayerDataOptions[Selected](Target, Input) | |||
| end) | |||
|
|
|||
| RegisterNetEvent('qb-admin:server:SaveCar', function(mods, vehicle, plate) | |||
There was a problem hiding this comment.
This should call https://qbox-project.github.io/resources/core/functions/server#spawnvehicle. It should not be calling the database directly.
There was a problem hiding this comment.
i will do all thing what u said
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist