Fix authorizedHelicopterS typo and removed export hasitem #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solareon
requested changes
Dec 6, 2023
| @@ -155,7 +155,7 @@ end) | |||
| ---Use bandage on nearest player to treat their wounds. | |||
| ---Intended to be invoked by client or server. | |||
| RegisterNetEvent('hospital:client:TreatWounds', function() | |||
| if not exports.qbx_core:HasItem('bandage') then | |||
| if not HasItem('bandage') then | |||
There was a problem hiding this comment.
Same for this to use the ox_inventory Search method.
| @@ -114,7 +114,7 @@ end) | |||
| ---Use first aid on nearest player to revive them. | |||
| ---Intended to be invoked by client or server. | |||
| RegisterNetEvent('hospital:client:RevivePlayer', function() | |||
| if not exports.qbx_core:HasItem('firstaid') then | |||
| if not HasItem('firstaid') then | |||
There was a problem hiding this comment.
This should be using the ox_inventory Search. While this functionally works this is a deprecated function that may be removed in the future.
https://overextended.dev/ox_inventory/Functions/Client#search
Manason
suggested changes
Dec 6, 2023
| @@ -300,7 +300,7 @@ CreateThread(function() | |||
| end | |||
|
|
|||
| for _, coords in pairs(sharedConfig.locations.helicopter) do | |||
| createGarage(config.authorizedHelicopters, Lang:t('info.heli_plate'), coords) | |||
| createGarage(config.authorizedHelicopter, Lang:t('info.heli_plate'), coords) | |||
There was a problem hiding this comment.
authorizedHelicopters actually sounds like it should be the correct name? Maybe change the config to match instead of changing here.
|
you are right. I didn't se your pr about the same. I will close this and wait for your ps to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a typo on the authorizedHelicopter config vaue, on the client file was called authorizedHelicopters.
Trere was also an export for HasItem "exports.qbx_core:HasItem" but HasItem should be called directly.
Checklist