Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: /911p multiple parameters #153

Merged
merged 3 commits into from
Jan 11, 2025
Merged

fix: /911p multiple parameters #153

merged 3 commits into from
Jan 11, 2025

Conversation

sw4m
Copy link
Contributor

@sw4m sw4m commented Jan 10, 2025

Description

Fixes an issue with sending a /911p call with multiple words/parameters.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@sw4m sw4m marked this pull request as ready for review January 10, 2025 09:49
Frowmza
Frowmza previously approved these changes Jan 11, 2025
@Frowmza Frowmza dismissed their stale review January 11, 2025 16:32

Accidental approval

@Frowmza
Copy link
Contributor

Frowmza commented Jan 11, 2025

We don't need to sub nor concat the table, Ox already doing this for us, simply just use longString type instead of string in message param, because even if this works, what if user started the message with a number, then the message wouldn't be a string and a error will occur

@LordChunk
Copy link

A small code snippet for reference :)
https://github.com/Qbox-project/qbx_ambulancejob/pull/150/files#diff-d4503a9550899ea7880582e02d5404019dbce696d1b27a7c63f18b99eddeb088R97-R99

@sw4m
Copy link
Contributor Author

sw4m commented Jan 11, 2025

We don't need to sub nor concat the table, Ox already doing this for us, simply just use longString type instead of string in message param, because even if this works, what if user started the message with a number, then the message wouldn't be a string and a error will occur

Is this what you meant?

@Ehbw Ehbw merged commit 64ab930 into Qbox-project:main Jan 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/911p errors when using multiple args in command
4 participants