Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide hud components #126

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Hide hud components #126

merged 1 commit into from
Oct 21, 2024

Conversation

AfterLifeStudio
Copy link
Contributor

there is no need to use the hidehudcomponentthisframe native every frame you can just change the size of the component to zero and reset it when you want to show the component and also you dont need displayammothisframe because the first native we are using also do same job

Copy link
Member

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this cause incompatibility issues with natives that would rely on the hud component existing? Possibly https://docs.fivem.net/natives/?_0xBC4C9EA5391ECC0D?

@AfterLifeStudio
Copy link
Contributor Author

hey guys can you approve this

@mafewtm
Copy link
Member

mafewtm commented Oct 21, 2024

Manason's question was never answered. We need to know if these will now still be active or not. All this seems to do is set the size to 0, not disable them.

@AfterLifeStudio
Copy link
Contributor Author

Manason's question was never answered. We need to know if these will now still be active or not. All this seems to do is set the size to 0, not disable them.

sorry for not replying in the pr but i did inform him about this in the voice channel that even the hidehudcomponent only hides it but does not disable it so technically its still showing the ui but the native is hiding it
so its all good for this pr you can ask manason

@mafewtm mafewtm merged commit d2ac000 into Qbox-project:main Oct 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants