Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(car wash): Coordinates and labels missing from config #33

Merged
merged 2 commits into from
Sep 23, 2023

Conversation

jnccloud
Copy link
Contributor

@jnccloud jnccloud commented Sep 22, 2023

PR #31 refactored the config and carwash loop resulting in an error on startup. Additionally the label was removed from config without refactoring the blip. Was #31 even tested?

Fixes #32

Description

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

Remove "coords" from carwash loop
Hardcoded "Car Wash" into it since this resource doesn't make use of locales
@jnccloud jnccloud changed the title Update carwash.lua fix(car wash): Coordinates and labels missing from config Sep 22, 2023
@mafewtm
Copy link
Member

mafewtm commented Sep 23, 2023

Yes it was but a mistake was made. In a PR im about to post, itll be fixed

Copy link
Member

@mockdot mockdot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need to make sure since we're doing a lot of these ports to OX PR's that they are tested properly before merging.

@Manason
Copy link
Member

Manason commented Sep 23, 2023

Yes it was but a mistake was made. In a PR im about to post, itll be fixed

#34 Does not fix the bug that this PR fixes.

@Manason Manason merged commit b7e1110 into Qbox-project:main Sep 23, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Carwash Coords
4 participants