Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove id command #46

Closed
wants to merge 1 commit into from
Closed

fix: remove id command #46

wants to merge 1 commit into from

Conversation

mafewtm
Copy link
Member

@mafewtm mafewtm commented Nov 12, 2023

Description

Remove the ID Command in favor of having it in qbx_scoreboard

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My code fits the style guidelines.
  • My PR fits the contribution guidelines.

Comment on lines -5 to -10
lib.addCommand('id', {
help = 'Check Your ID #',
}, function(source)
TriggerClientEvent('QBCore:Notify', source, 'ID: '..source)
end)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this have to do with qbx_socreboard?

Copy link
Member Author

@mafewtm mafewtm Nov 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured I'd put it in the scoreboard where you see your ID when you press HOME anyway instead of just leaving it in smallresources. If you know a better place to put it, we can move it.

@mafewtm mafewtm closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants