refactor: improve consumeables logic even more #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we just rename the stupid consumable table names? Idk why they made it ConsumablesEat and whatnot |
that would be better |
BerkieBb
approved these changes
Feb 12, 2024
What would you rename them to 🤔 |
|
Combine them into a consumables table and give them each a type |
Berkie ily smart guy |
|
I hate annotations. |
mafewtm
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improves the consumeables logic more,
Added config for a few things:
animation / prop,
stress relief,
sustenance,
Alcohol level (how drunk you get)
Also fixed how the random worked, setting a random value in config WILL NOT make a new value everytime..
Also changed to use client callback instead of client events, sounds better to me, might be wrong tho.
Needs testing, but it's way too late for me to do that lol
Checklist