refactor: rename config value to be clearer as to the behavior (#105)

* refactor: rename config value to be clearer as to the behavior

* fix nil check

* fix: using number not table

client/main.lua

@@ -116,7 +116,7 @@ local function showHotwiringLabel(vehicle)
         -- Hotwiring while in vehicle, also keeps engine off for vehicles you don't own keys to
         if not isVehicleAccessible and cache.seat == -1 then
             local isVehicleRunning = GetIsVehicleEngineRunning(vehicle)
-            if config.keepVehicleRunning and isVehicleRunning then
+            if config.getKeysWhenEngineIsRunning and isVehicleRunning then
                 TriggerServerEvent('qb-vehiclekeys:server:AcquireVehicleKeys', plate)
             else
                 SetVehicleNeedsToBeHotwired(vehicle, false)

config/client.lua

@@ -83,8 +83,7 @@ local defaultHoldupAnim = { dict = 'mp_am_hold_up', clip = 'holdup_victim_20s' }
 return {
     vehicleMaximumLockingDistance = 5.0, -- Minimum distance for vehicle locking
 
-    -- Lockpick Settings
-    keepVehicleRunning = true,
+    getKeysWhenEngineIsRunning = true, -- when enabled, gives keys to a player who doesn't have them if they enter the driver seat when the engine is running
 
     -- Carjack Settings
     carjackEnable = true,                -- Enables the ability to carjack pedestrian vehicles, stealing them by pointing a weapon at them

shared/functions.lua

@@ -87,7 +87,7 @@ function public.getVehicleConfig(vehicle)
     local model = GetEntityModel(vehicle)
     local filteredConfig = {
         modelConfig = config.vehicles.models[model],
-        categoryConfig = config.vehicles.categories[VEHICLES[model].category],
+        categoryConfig = config.vehicles.categories[VEHICLES[model]?.category],
         typeConfig = config.vehicles.types[GetVehicleType(vehicle)],
         defaultConfig = config.vehicles.default
     }

types.lua

@@ -9,6 +9,6 @@
 ---@field carjackingImmune? boolean
 ---@field lockpickImmune? boolean
 ---@field shared? boolean
----@field removeNormalLockpickChance number ratio
----@field removeAdvancedLockpickChance number ratio
----@field findKeysChance number ratio
+---@field removeNormalLockpickChance? number ratio
+---@field removeAdvancedLockpickChance? number ratio
+---@field findKeysChance? number ratio