Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: notify spam #142

Merged
merged 2 commits into from
Oct 3, 2024
Merged

fix: notify spam #142

merged 2 commits into from
Oct 3, 2024

Conversation

Manason
Copy link
Contributor

@Manason Manason commented Oct 3, 2024

When giving keys via the bridge (by plate) many vehicles match to the plate, so many keys are given and the notifications per vehicle spam the player. This changes the bridge to only show one notification even if keys are given to many vehicles.

  • Adds a skipNotification optional field to RemoveKeys and GiveKeys
  • Bridge handles its own notifications

bridge/qb/server.lua Outdated Show resolved Hide resolved
@Manason Manason requested a review from D4isDAVID October 3, 2024 15:43
@D4isDAVID D4isDAVID merged commit 8ac47a9 into main Oct 3, 2024
4 checks passed
@D4isDAVID D4isDAVID deleted the fix-notify-spam branch October 3, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants