refactor: feat: ! Refactoring and describing the lockpickDoor function moved to client/functions.lua #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manason
approved these changes
Apr 16, 2024
|
Looks like there are some conflicts. Should have probably merged yours first. Sorry :( |
|
I will resolve conflicts soon |
Manason
reviewed
Apr 19, 2024
Comment on lines
+16
to
-7
| function public.isCloseToCoords(coord1, coord2, distance) | ||
| return #(coord1 - coord2) < distance | ||
| end |
There was a problem hiding this comment.
This seems like an unnecessary abstraction
There was a problem hiding this comment.
This function was already in the code. It improves readability a little bit, which is why I started using it.
Manason
reviewed
Apr 19, 2024
|
|
||
| --[[ Manifest ]]-- | ||
| dependencies { | ||
| 'ox_lib', |
There was a problem hiding this comment.
This will make it so if you restart ox_lib, then this resource will be stopped. Is that the desired behavior?
There was a problem hiding this comment.
There are a few lib.callbacks in the script, so without ox_lib it may throw errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The lockpickDoor, attemptPoliceAlert, isBlacklistedWeapon, isBlacklistedVehicle functions and their helper functions have been moved to clients/functions.lua
These can be used in main.lua using import, inspired by ox_target
Some conditions have been added to enable the usage of the lock pick.
When opened, the distance between the vehicle and the player's ped gets checked.
Previously, opening the lock on trucks was done in the middle of the vehicle. Now you just have to approach the driver's door.
Used statebag to hold information about the lock.
Checklist
BREAKING CHANGE:
In the statebag of the vehicle there is a saved information on whether it has been opened with a lock pick.