Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the constraints & remove financing columns #3

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Conversation

TonybynMp4
Copy link
Contributor

Description

Related to Qbox-project/qbx_vehicleshop#64
Also fixes potential issues with conflicting charsets / collate

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Copy link
Contributor

@Manason Manason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider how many scripts will break that would be accessing this table directly for finance data. Doing this may prevent other vehicle shop resources from being compatible with qbox. We may want to hold off on this for now. What do you think?

vehicles.sql Outdated Show resolved Hide resolved
vehicles.sql Show resolved Hide resolved
@TonybynMp4
Copy link
Contributor Author

We should consider how many scripts will break that would be accessing this table directly for finance data. Doing this may prevent other vehicle shop resources from being compatible with qbox. We may want to hold off on this for now. What do you think?

Considering vehicleshop had the sql for it, i'd assume they also have it anyway.
qbx_vehicles should not have the vehicleshop db stuff, just like vehicleshop shouldn't have the vehicles table, if it breaks, it's the responsibility of the script creator to maintain compatibility and not ours.

vehicles.sql Show resolved Hide resolved
@mafewtm mafewtm merged commit 0198d9d into main Mar 7, 2024
4 checks passed
@mafewtm mafewtm deleted the vehShop branch March 7, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants