Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: style fixes #12

Merged
merged 2 commits into from
Dec 24, 2023
Merged

refactor: style fixes #12

merged 2 commits into from
Dec 24, 2023

Conversation

mafewtm
Copy link
Member

@mafewtm mafewtm commented Dec 24, 2023 •
edited
Loading

Description

  • Standardize ' over "
  • camelCase functions and variables
  • Replace GetHashKey with joaat
  • Utilize the ox_lib caching and requestModel where necessary
  • Fix some netId linting errors from a previous pr

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@mafewtm
Copy link
Member Author

mafewtm commented Dec 24, 2023

The last three linting errors are regarding Polyzone which will be replaced in the next PR

@ChatDisabled ChatDisabled merged commit 03d56b9 into Qbox-project:main Dec 24, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dusan01 dusan01 dusan01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafewtm @dusan01 @ChatDisabled