Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap vehicle model check. #58

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Swap vehicle model check. #58

merged 2 commits into from
Feb 7, 2024

Conversation

Randolio
Copy link
Contributor

@Randolio Randolio commented Feb 1, 2024

This adds a check to make sure the model you are trying to swap to exists/streamed before making the swap. Without this, if you have a "vehicle364" (which isn't streamed) as the example model you are trying to swap to, it will delete the previous vehicle and attempt to load the new one and fail, making it so you can not interact with the vehicle in that particular spot unless you relog.

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

client/main.lua Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Randolio Randolio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good?

@Randolio Randolio requested a review from Manason February 2, 2024 14:43
@mafewtm mafewtm merged commit 3708eac into Qbox-project:main Feb 7, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants