Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation to pt-br and loadmodel for low specs #73

Closed
wants to merge 15 commits into from

Conversation

mur4i
Copy link

@mur4i mur4i commented May 22, 2024

Description

Translation to pt-br and loadmodel for low specs

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Copy link
Contributor

@BerkieBb BerkieBb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the IsPedInAnyVehicle checks to cache.vehicle and the dead checks to the dead check export, exports.qbx_medical:isDead()

@@ -507,7 +523,7 @@ end
---@param coords vector4
---@return number vehicleEntity
local function createShowroomVehicle(model, coords)
lib.requestModel(model, 1000)
lib.requestModel(model, 5000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhabs may be worth use requestModelTimeout

@@ -598,6 +614,8 @@ RegisterNetEvent('qbx_vehicleshop:client:testDrive', function(args)
local plate = 'TEST'..lib.string.random('1111')
local netId = lib.callback.await('qbx_vehicleshop:server:spawnVehicle', false, args.vehicle, testDrive.spawn, plate)
testDriveVeh = netId
while not NetworkGetEntityFromNetworkId(netId) do Wait(100) end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lib.waitFor should be better option

"transfervehicle_confirm": "Confirmar a troca de %s %s por $ %s"
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the last line should be empty

@@ -29,13 +29,13 @@ end

local function confirmationCheck()
local alert = lib.alertDialog({
header = 'Wait a minute!',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not language files. The default language for prompts is English.
If you want to translate this messages, create keys in locales/en.json and locales/es.json.

@Manason
Copy link
Contributor

Manason commented Jun 19, 2024

Closing as author has not been responsive. Feel free to re-open.

@Manason Manason closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants