Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement unitary AQC #45

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Implement unitary AQC #45

wants to merge 1 commit into from

Conversation

garrison
Copy link
Member

@garrison garrison commented Nov 27, 2024

This is very rough (untested so far, but lint passes). It follows the same style as #35, which itself is motivated by the desire that implement both state AQC and unitary AQC alongside one another in this package.

The main thing left to do is to show how to construct the target tensor network. There is a quimb tutorial that does this, but it seems to construct the unitary in dense form first, and we want to avoid this.

@garrison garrison added enhancement New feature or request quimb labels Nov 27, 2024
@garrison garrison added this to the 0.2.0 milestone Nov 27, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12043918223

Details

  • 9 of 28 (32.14%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.9%) to 95.511%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_addon_aqc_tensor/simulation/quimb/init.py 4 11 36.36%
qiskit_addon_aqc_tensor/objective.py 5 17 29.41%
Totals Coverage Status
Change from base Build 12043748422: -2.9%
Covered Lines: 617
Relevant Lines: 646

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request quimb
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants