-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to compile with Intel MKL + Use it in MPS simulation #1913
Open
Patataman
wants to merge
24
commits into
Qiskit:main
Choose a base branch
from
Patataman:PR-MKL
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix seg fault bc arrays were too big
I think MKL should be optional that will not be included in distribution package of Aer. In this PR, MKL is enabled by setup option, so users who want to use MKL can build from the source |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hello, this PR add the capability of compiling against Intel MKL, and using its functions in the MPS simulation method.
It is build over the LAPACK SVD (#1897).
I understand that you may not like it as this will imply contemplate both, OpenBLAS and Intel MKL when developing. So, I am prepared for a full rejection of the PR.
Details and comments
python ./setup.py bdist_wheel -DMKL=True
As in my other PRs, I have used RQC (https://arxiv.org/pdf/2207.14280.pdf) to test the performance:
Server specs
And, the average time (in seconds) from 5 different executions:
EDIT: Added results for depth 15