Don't decode
a unicode string when using git version
#2264
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #907, the git sha1 was added to the version string on development builds. In #2158,
encoding="utf-8"
was added in_minimal_ext_cmd
, which changed the output from a bytestring to a regular string. However, the original code path still expects a bytestring and calls.decode()
on it. This fixes it in the way most obvious to me.Details and comments
I am a bit puzzled that I am the first to notice this. My development builds of Aer otherwise result in the
.decode()
failing as soon as the package is imported.Even with this change, I am still unable to build and run qiskit-aer in an Ubuntu 24.04 container. The bug I get after this patch isEDIT: The above error resolved as soon as I changed directories away from the root directory of this repo before importing
qiskit_aer
.