Remove RuntimeOptions
#2301
Open
Remove RuntimeOptions
#2301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElePT
added
the
Changelog: Removal
ElePT
reviewed
Sep 12, 2025
There was a problem hiding this comment.
Another deprecation slip-up from the runtime programs era. This should have been deprecated when it stopped being useful server-side. At this point, I again see this cleanup as a bugfix rather than a new deprecation, given that the functionality stopped working a long time ago. I am fine with the removal, I would just point out the release note to document it.
ElePT
reviewed
Sep 29, 2025
There was a problem hiding this comment.
I have found a downstream package that depended on RuntimeOptions. Given that we are in no rush to remove the class, I suggest turning this PR into a deprecation PR instead of a removal. I would keep the typehint changes though, they reflect the current status better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Draft PR for now, still need to test which options actually work. Currently more of a POC to show that we don't need the
RuntimeOptionsclass anymore and it's confusing to have this extra "options" class.Details and comments
Fixes #2300