Add rep_delay validation #2389
Open
Add rep_delay validation #2389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt474
added
the
Changelog: New Feature
kt474
commented
Sep 4, 2025
| if rep_delay < rep_delay_range[0] or rep_delay > rep_delay_range[1]: | ||
| raise ValueError( | ||
| f"rep_delay {rep_delay} is not in the backend rep_delay_range {rep_delay_range}" | ||
| ) |
There was a problem hiding this comment.
I didn't want to repeat this code but I don't think there's a way to do this directly in the ExecutionOptions because we need to check the backend config for the rep_delay_range
ElePT
reviewed
Sep 8, 2025
There was a problem hiding this comment.
I am in favor of having checks, but I am wondering which validations should be the client's responsibility and which should be the validation service's responsibility. I would have expected this to be one of the parameters checked in the validation process. I think that the overall pipeline should be synchronized a bit better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding client side validation to make sure
rep_delayvalue is within the backend'srep_delay_range.Details and comments
Fixes #2387