Update ci configuration to use supported python version #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The repo hasn't been updated in some time as the tests were working as-is. But in the meantime the CI configuration has bitrotted slightly. The tests are all built around using python 3.8 which is now unsupported both by qiskit and cPython. This commit updates the configuration to fix this and unblock CI.
jakelishman
reviewed
Feb 26, 2025
| from qiskit_neko.version import __version__ | ||
| from qiskit_neko.version import __version__ as __version__ |
There was a problem hiding this comment.
This was the only ruff error after moving off of pylint (which was causing the install issues). It said either do this or add __all__ and put __version__ in it.
There was a problem hiding this comment.
that's a pretty stupid lint rule, but ok haha
releasenotes/config.yaml
Outdated
There was a problem hiding this comment.
I guess it wasn't doing anything, but did you mean to delete it?
There was a problem hiding this comment.
Yes, as part of removing unnecessary requirements I removed it along with the reno dev requirement.
There was a problem hiding this comment.
if it wasn't doing anything I am in favor of deleting it
jakelishman
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo hasn't been updated in some time as the tests were working as-is. But in the meantime the CI configuration has bitrotted slightly. The tests are all built around using python 3.8 which is now unsupported both by qiskit and cPython. This commit updates the configuration to fix this and unblock CI.