🏗️ Data folder refactorization #1509
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
* First refactorization for files * Completed use cases for list end-point * Renamed storage to file_storage * Migrated files to file_storage * Migrated get files to the new service * Check if function exists first * Separated end-points to the new provider * Improved tests * Restore original fixtures * Solved the problem with the external if * Added Literal type in the FileStorage service * functions methods refactorization * use self.username instead of the variable * run path sanitization only one time * function title is mandatory for file storage * fix black * Updated 403 by 404 * Updated swagger for list * Makes use of enum with integers * use is instead of equals * unify path build * get_function refactor
|
Failing tests at this point of the development are expected. API changes will require client migrations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Details and comments
TODO