Feat/save result into result store #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tansito
requested changes
Jan 28, 2025
gateway/tests/resources/fake_media/test_user/results/1a7947f9-6ae8-4e3d-ac1e-e7d608deec82.json
Outdated
Show resolved
Hide resolved
…job-results-from-result-store
…job-results-from-result-store
Tansito
reviewed
Jan 29, 2025
gateway/tests/resources/fake_media/test_user/results/8317718f-5c0d-4fb6-9947-72e480b8a348.json
Show resolved
Hide resolved
Tansito
approved these changes
Jan 29, 2025
Tansito
added a commit
that referenced
this pull request
Feb 10, 2025
* feat: new ResultStorage class * fix doc * fix lint * Feat/save result into result store (#1570) * add job access polocies * fix lint * apply review suggestions * fix: create job repository * fix job id * fix result asignment * fix test and lint * feat: retrieve job results from result storage * remove result file * retrieve job results * apply review suggestions * fix typo * add test fake file * fix test media path for retrieve result * remove prints * fix lint * remove unnecesary file * revert file deletion * apply partial review suggestions * fix serializers * Feat/remove result from list endpoint (#1577) * feat: remove result from list endpoint * fix lint * move query_set to repository * refactor jobs queryset to repository * fix lint * fix lint * fix lint * fix lint * fix error * remove filter querset --------- Co-authored-by: Pablo Aragón <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR continues the use case about saving job results in files instead of database.
This modifies the POST /result endpoint to save the result using the ResultStorare