Authentication logic refactor #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tansito
commented
Feb 19, 2025
| self.authorization_token = authorization_token | ||
| self.access_token = None | ||
|
|
||
| def _get_network(self, access_token: str): |
There was a problem hiding this comment.
This is something very interesting @paaragon . If I use __get_network here I cannot mock the method because as a private method the test cannot access to the method.
I didn't remember this so probably we should stop using that nomenclature, what do you think?
Tansito
commented
Feb 19, 2025
| """ | ||
| The main objective of this class is to manage the access to the model | ||
| """ | ||
|
|
||
| def get_or_create_by_id(self, user_id: str) -> type[AbstractUser]: |
There was a problem hiding this comment.
I also found a way to type that we are returning a user with type[AbstractUser]. This way the linter doesn't complain 😂
paaragon
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR will refactor the entire authentication flow to prepare the project to introduce additional services like IBM Cloud. This is a 100% refactor, there is no change in the logic or the output. So the main purpose is the simplification and improvement of the codebase.
Details and comments