Raise minimum python version to 3.9 #12910
Conversation
mtreinish
added
the
Changelog: API Change
|
One or more of the following people are relevant to this code:
|
Qiskit 1.2.0 was the final minor version release of qiskit with Python 3.8 support. As Python 3.8 is going EoL before the next Qiskit minor release 1.3.0 we can drop support for running with 3.8 on the main branch now. This commit makes that change and updates everything using python 3.8 currently to use our new minimum instead.
mtreinish
force-pushed
the
py39-now-and-forever
branch
from
7b4e131
to
b0d1d64
Compare
Pull Request Test Coverage Report for Build 10801601513Details
💛 - Coveralls |
There was a problem hiding this comment.
This all looks good to me.
I'm thinking that the CI tests might have to do with numpy deprecating np.product after the release of Numpy 1.25, this an old release but it also happens to be the point at which Numpy stopped supported Python 3.8. I don't know how deep this issue goes but hopefully this helps shine a light.
|
Thanks, yeah it's catching a real issue we'll need to fix by updating the test setup. Since the qpy backwards compatibility tests are installing historical releases of qiskit that predate numpy 1.25 those earlier releases are not compatible with the newer numpy releases. We'll have to update: https://github.com/Qiskit/qiskit/blob/main/test/qpy_compat/process_version.sh#L48-L50 to set a back version for compatibility. |
Now that we're running Python 3.9 as the base version we are encountering compatibility issues with some of our dependencies because 3.9 supports newer versions of things like numpy than older Qiskit releases were compatible with. The only way to work around this is to pin the versions when installing historical versions. To start this sets a single constraints version since we can get away with using the same version for everything. In the future though it is possible that we'll need separate files for different historical releases.
|
This should be good to go now (assuming I updated the correct reference images). |
There was a problem hiding this comment.
Thank you for this, glad to see it works well now. Just wondering whether we should remove support for 3.8 in asv too. I think we only need to change this line:
Line 20 in 86a1b49
Other than that, it LGTM!
| # Normally we test min and max version but we can't run python | ||
| # 3.9 on arm64 until actions/setup-python#808 is resolved | ||
| python-version: ["3.10", "3.12"] |
There was a problem hiding this comment.
This issue appears to be closed now actions/setup-python#808, are we planning on making any updates?
There was a problem hiding this comment.
We can fix this in a follow-up. There isn't a super big motivation to change it as using 3.10 works fine, but if we could get 3.9 running instead of 3.10 that would at least make everything consistent. But I think we can also look at doing it as part of #12807 too
Yes I think we should, I updated this in: 9d19eae |
In the recently merged Qiskit#12910 the minimum Python version was raised to 3.9. As part of this the cibuildwheel config was updated to skip 38 uilds since they wont work anymore. However that PR missed that there was an additional skip config in for the 32 bit builds in the job definition. This commit adds the missing skip so the 32bit wheel builds will work as well.
* Prepare 1.3.0b1 release This commit changes the version strings from 1.3.0 to 1.3.0b1 in preparation for tagging the 1.3.0b1 pre-release. After we publish the 1.3.0b1 tag we should switch the version number back to 1.3.0 to continue developing the 1.3.0 release series as we approach the actual release. * Also skip 3.8 builds on 32 bit platforms In the recently merged #12910 the minimum Python version was raised to 3.9. As part of this the cibuildwheel config was updated to skip 38 uilds since they wont work anymore. However that PR missed that there was an additional skip config in for the 32 bit builds in the job definition. This commit adds the missing skip so the 32bit wheel builds will work as well.
Summary
Qiskit 1.2.0 was the final minor version release of qiskit with Python 3.8 support. As Python 3.8 is going EoL before the next Qiskit minor release 1.3.0 we can drop support for running with 3.8 on the main branch now. This commit makes that change and updates everything using python 3.8 currently to use our new minimum instead.
Details and comments